This repository has been archived by the owner on Nov 16, 2020. It is now read-only.
Workaround for ovfenv not working after a reboot #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjs
reviewed
Nov 28, 2018
kars7e
force-pushed
the
fix-missing-ovf
branch
from
9f547d7
to
85c04b8
Compare
Add a wrapper around ovfenv that checks if ovf properties are properly returned. If not, reads the data from cache stored on disk. Additional fixes: - Correctly sets the locale - creates firstboot file so that firstboot-only scripts do not execute again Testing: - tested in fusion 11.0.2 - tested on VMC
kars7e
force-pushed
the
fix-missing-ovf
branch
from
85c04b8
to
c78db1a
Compare
|
@zjs thanks for a thorough review! I added the wrapper to |
zjs
approved these changes
Nov 28, 2018
3 tasks
pzmrzy
pushed a commit
to pzmrzy/dispatch
that referenced
this pull request
Dec 4, 2018
Add a wrapper around ovfenv that checks if ovf properties are properly returned. If not, reads the data from cache stored on disk. Additional fixes: - Correctly sets the locale - creates firstboot file so that firstboot-only scripts do not execute again Testing: - tested in fusion 11.0.2 - tested on VMC
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a wrapper around ovfenv that checks if ovf properties are properly
returned. If not, read the data from the cache stored on disk.
Fixes #754
Fixes #747
Additional fixes:
again
HOSTinstead ofHOSTNAMEasHOSTNAMEis a built-in variableTesting: