Merge #875

875: [jjo] fix: improve kubeprod removal (e2e and docu) r=jjo a=jjo

Fixes #739.

Co-authored-by: JuanJo Ciarlante <juanjosec@gmail.com>

Jenkinsfile

@@ -251,6 +251,11 @@ def runIntegrationTest(String description, String kubeprodArgs, String ginkgoArg
                 sh "kubecfg delete kubeprod-manifest.jsonnet || true"
             }
             container('kubectl') {
+                sh """
+                  timeout 60 kubectl get -n kubeprod challenges.acme.cert-manager.io -oname | \
+                    timeout 60 xargs -rtI{} kubectl patch -n kubeprod {} \
+                      --type=json -p='[{"op": "remove", "path": "/metadata/finalizers"}]' || true
+                """
                 sh "kubectl wait --for=delete ns/kubeprod --timeout=300s || true"
             }
         }

docs/quickstart-aks.md

@@ -173,6 +173,14 @@ Re-run the `kubeprod install` command, from the [Deploy BKPR](#step-2-deploy-bkp
 
 ### Step 2: Wait for the `kubeprod` namespace to be deleted
 
+  ```bash
+  # Specific finalizers cleanup, to avoid kubeprod ns lingering
+  # - cert-manager challenges if TLS certs have not been issued
+  kubectl get -n kubeprod challenges.acme.cert-manager.io -oname| \
+    xargs -rtI{} kubectl patch -n kubeprod {} \
+      --type=json -p='[{"op": "remove", "path": "/metadata/finalizers"}]'
+  ```
+
   ```bash
   kubectl wait --for=delete ns/kubeprod --timeout=300s
   ```

docs/quickstart-eks.md

@@ -232,6 +232,14 @@ Re-run the `kubeprod install` command from the [Deploy BKPR](#step-3-deploy-bkpr
 
 ### Step 2: Wait for the `kubeprod` namespace to be deleted
 
+  ```bash
+  # Specific finalizers cleanup, to avoid kubeprod ns lingering
+  # - cert-manager challenges if TLS certs have not been issued
+  kubectl get -n kubeprod challenges.acme.cert-manager.io -oname| \
+    xargs -rtI{} kubectl patch -n kubeprod {} \
+      --type=json -p='[{"op": "remove", "path": "/metadata/finalizers"}]'
+  ```
+
   ```bash
   kubectl wait --for=delete ns/kubeprod --timeout=300s
   ```

docs/quickstart-generic.md

@@ -136,6 +136,14 @@ Re-run the `kubeprod install` command, from the [Deploy BKPR](#step-2-deploy-bkp
 
 ### Step 2: Wait for the `kubeprod` namespace to be deleted
 
+  ```bash
+  # Specific finalizers cleanup, to avoid kubeprod ns lingering
+  # - cert-manager challenges if TLS certs have not been issued
+  kubectl get -n kubeprod challenges.acme.cert-manager.io -oname| \
+    xargs -rtI{} kubectl patch -n kubeprod {} \
+      --type=json -p='[{"op": "remove", "path": "/metadata/finalizers"}]'
+  ```
+
   ```bash
   kubectl wait --for=delete ns/kubeprod --timeout=300s
   ```

docs/quickstart-gke.md

@@ -217,6 +217,14 @@ Re-run the `kubeprod install` command, from the [Deploy BKPR](#step-2-deploy-bkp
 
 ### Step 2: Wait for the `kubeprod` namespace to be deleted
 
+  ```bash
+  # Specific finalizers cleanup, to avoid kubeprod ns lingering
+  # - cert-manager challenges if TLS certs have not been issued
+  kubectl get -n kubeprod challenges.acme.cert-manager.io -oname| \
+    xargs -rtI{} kubectl patch -n kubeprod {} \
+      --type=json -p='[{"op": "remove", "path": "/metadata/finalizers"}]'
+  ```
+
   ```bash
   kubectl wait --for=delete ns/kubeprod --timeout=300s
   ```