Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

PR #177 is not backwards compatible #190

Closed
falfaro opened this issue Nov 1, 2018 · 2 comments
Closed

PR #177 is not backwards compatible #190

falfaro opened this issue Nov 1, 2018 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@falfaro
Copy link
Contributor

falfaro commented Nov 1, 2018

PR #177 is not backwards compatible. It introduces a new field in the JSON configuration file named authz_domain which didn't exist before the PR.

I have a GKE cluster that was deployed with kubeprod manifests before PR #177. This how the JSON configuration file looks like:

{
  "dnsZone": "...",
  "contactEmail": "...",
  "externalDns": {
    "credentials": "...",
    "project": "..."
  },
  "oauthProxy": {
    "client_id": "...",
    "client_secret": "...",
    "cookie_secret": "...",
    "google_groups": [],
    "google_admin_email": "",
    "google_service_account_json": ""
  }
}

Running kubecfg update after PR #177 results in the following error:

 kubecfg update kubeprod-manifest.jsonnet
ERROR Error reading kubeprod-manifest.jsonnet: RUNTIME ERROR: Field does not exist: authz_domain
        file:///Users/falfaro/go/src/github.com/bitnami/kube-prod-runtime/manifests/platforms/gke.jsonnet:110:35-67     object <anonymous>
        file:///Users/falfaro/go/src/github.com/bitnami/kube-prod-runtime/manifests/lib/kube.libsonnet:32:25-29 thunk from <thunk from <function <anonymous>>>
        <std>:659:15-22 thunk <val> from <function <format_codes_arr>>
        <std>:666:27-30 thunk from <thunk <s> from <function <format_codes_arr>>>
        <std>:536:22-25 thunk from <function <format_code>>
        <builtin>       builtin function <toString>
        <std>:666:15-60 thunk <s> from <function <format_codes_arr>>
        <std>:671:24-25 thunk from <thunk <s_padded> from <function <format_codes_arr>>>
        <std>:451:30-33 thunk from <thunk from <function <pad_left>>>
        <builtin>       builtin function <length>
        ...
        <std>:451:7-38  function <pad_left>
        <std>:451:7-44  function <pad_left>
        <std>:671:15-39 thunk <s_padded> from <function <format_codes_arr>>
        <std>:677:55-63 thunk from <function <format_codes_arr>>
        <std>:677:51-63 thunk from <function <format_codes_arr>>
        <std>:677:11-64 function <format_codes_arr>
        <std>:721:7-46  function <anonymous>
        <std>:203:7-23  function <anonymous>

        During manifestation
@falfaro
Copy link
Contributor Author

falfaro commented Nov 1, 2018

I think the solution consists of modifying the manifests that rely on authz_domain to adopt a sane default value (whichever we were using before PR #177) which I believe was "*" for AKS (not sure about GKE).

@falfaro falfaro self-assigned this Nov 1, 2018
@falfaro falfaro added the bug Something isn't working label Nov 1, 2018
@falfaro falfaro closed this as completed Nov 1, 2018
@arapulido
Copy link
Contributor

We are closing this PR because #177 was merged before 1.0-rc1 was released, and therefore, we can assume a backwards compatibility

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants