This repository has been archived by the owner on Feb 9, 2022. It is now read-only.
Feat: Add Cloud-Custodian policies to clean-up Jenkins-BKPR staled resources #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 12, 2020 13:09
…sources Signed-off-by: David Barranco <dbarranco@vmware.com>
Signed-off-by: David Barranco <dbarranco@vmware.com>
Signed-off-by: David Barranco <dbarranco@vmware.com>
Signed-off-by: David Barranco <dbarranco@vmware.com>
jjo
reviewed
Aug 12, 2020
jenkins/cloud-custodian/Jenkinsfile
Outdated
| sh "docker pull gcr.io/bitnami-images/sre-cloud-custodian:${env.CUSTODIAN_VERSION}" | ||
| } | ||
| } | ||
| stage("Download the Custodian policy files") { |
There was a problem hiding this comment.
Can't we make these files available "locally" in the same (Jenkins) workspace?
jenkins/cloud-custodian/azure.yaml
Outdated
| - type: value | ||
| key: name | ||
| op: regex | ||
| value: '^(pr-|trying-|staging-)' |
There was a problem hiding this comment.
Maybe also add .*bkpr ? to narrow this, obviously in case these match.
jenkins/cloud-custodian/google.yaml
Outdated
| - type: value | ||
| key: name | ||
| op: regex | ||
| value: '^(pr-|trying-|staging-)' |
jjo
approved these changes
Aug 12, 2020
Signed-off-by: David Barranco <dbarranco@vmware.com>
jbianquetti-nami
approved these changes
Aug 18, 2020
added 3 commits
August 18, 2020 11:04
Signed-off-by: David Barranco <dbarranco@vmware.com>
Signed-off-by: David Barranco <dbarranco@vmware.com>
Signed-off-by: David Barranco <dbarranco@vmware.com>
|
This is ready. I will move the improvements in the locking system to a different PR (after the CloudCustodian gets updated). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds a Jenkinsfile that will execute the Cloud-Custodian to enforce hygiene policies in the different accounts/projects/subscriptions used by Jenkins-BKPR for its continuous integration tests.
At this moment, the following cloud resources are covered:
AWS
Google
Azure
In this first iteration of the Cloud Custodian Jenkins pipeline, GCP won't be added to the periodic clean-ups as the delete operations have not been coded yet. I will sign the CLA and contribute to this project with these operations (they seem to be trivial).
Same case for some AWS resources.
Pipeline details
Next action items
Signed-off-by: David Barranco dbarranco@vmware.com