This repository has been archived by the owner on Dec 15, 2021. It is now read-only.
fixes bug so that configmap volumemounts are merged in deployment #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
reviewed
Nov 4, 2019
There was a problem hiding this comment.
Thanks for the PR @anaik-zam!
You need to format the file with gofmt in order to fix the error in the CI: gofmt -s -w
andresmgot
approved these changes
Nov 8, 2019
|
The image built in the CI is https://circleci.com/gh/kubeless/kubeless/2693#artifacts/containers/0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ref: [#1035]
Description:
Manually merge VolumeMounts in runtime container if defined in configmap.
Mergo doesn't add the VolumeMounts https://github.com/kubeless/kubeless/blob/master/pkg/utils/k8sutil.go#L376
possibly due to this error
TODOs: