Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Refactoring e2e tests to vsphere folder in tests/e2e/storage #353

Closed
pshahzeb opened this issue Oct 27, 2017 · 0 comments
Closed

Refactoring e2e tests to vsphere folder in tests/e2e/storage #353

pshahzeb opened this issue Oct 27, 2017 · 0 comments
Labels
P1 Tests
Milestone
Sprint - Flash

Comments

@pshahzeb
Copy link

pshahzeb commented Oct 27, 2017 •
edited

  1. As per request from k8s community, all tests related to vsphere cloud provider should be moved to a separate folder under tests/e2e/storage.
    E2E scale test for vSphere Cloud Provider Volume lifecycle operations kubernetes/kubernetes#54018 (comment)

  2. Move all environment vars reading to the vsphere suite level since most of them are common to all the tests.

  3. Move test utils to a common place which right now are redundant across many tests.
@pshahzeb pshahzeb added this to the Sprint - Aladin milestone Oct 27, 2017
@BaluDontu BaluDontu mentioned this issue Nov 6, 2017
Merged
@pshahzeb pshahzeb mentioned this issue Nov 7, 2017
Merged
@pshahzeb pshahzeb changed the title Moving all e2e tests to vsphere folder in tests/e2e/storage Refactoring e2e tests to vsphere folder in tests/e2e/storage Nov 7, 2017
@rjog rjog mentioned this issue Nov 17, 2017
Merged
@rjog rjog mentioned this issue Nov 28, 2017
Merged
@rjog rjog assigned rjog and unassigned divyenpatel Nov 28, 2017
@rjog rjog mentioned this issue Nov 29, 2017
Merged
k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this issue Dec 18, 2017
Merge pull request #56593 from vmware/e2e-test-layout-upstream
59b7c08 
Automatic merge from submit-queue (batch tested with PRs 54379, 56593, 56685, 54174, 57309). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

e2e test layout changes for vsphere (#398)

**What this PR does / why we need it**:
For vSphere Cloud Provider there are many tests added. But all those tests are in e2e/storage directory.
This change is an effort to make vsphere tests modular.
New package 'vsphere' under test/e2e/storage/ is being created.

**Which issue(s) this PR fixes**:
Fixes # vmware-archive#353


**Special notes for your reviewer**:
This is a change purely for vSphere tests
Engineers in VMware have reviewed it.

**Release note**:
```release-note
None
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P1 Tests
Projects
None yet
Milestone
Sprint - Flash
Development

No branches or pull requests
4 participants
@tusharnt @divyenpatel @pshahzeb @rjog