This repository has been archived by the owner on Jul 19, 2022. It is now read-only.
Add integration test #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glyn
commented
Nov 21, 2019
Change makefile to use ginkgo cli to run tests to avoid integration tests running in parallel with each other and conflicting. See onsi/ginkgo#111. Also fix a few bugs found by the tests. Fixes #8
|
Closing for now as I consider other approaches to testing controllers (projectriff/system#212). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change makefile to use ginkgo cli to run tests to avoid integration tests
running in parallel with each other and conflicting. See
onsi/ginkgo#111.
Also fix a few bugs found by the tests.
Fixes #8