This repository has been archived by the owner on Apr 8, 2022. It is now read-only.
Refactor watcher #61
Merged
Refactor watcher #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ngtuna
commented
Jul 13, 2017
ngtuna
commented
- use client-go v3.0
- use apimachinery
- remove k8s/kubernetes
- refactor controller loop
anguslees
reviewed
Jul 13, 2017
| @@ -44,39 +44,39 @@ var m = map[string]string{ | |||
| // New create new KubewatchEvent | |||
| func New(obj interface{}, action string) Event { | |||
| var namespace, kind, component, host, reason, status, name string | |||
| if apiService, ok := obj.(*api.Service); ok { | |||
| if apiService, ok := obj.(*v1.Service); ok { | |||
There was a problem hiding this comment.
Ouch.
import (
"fmt"
"k8s.io/apimachinery/pkg/api/meta"
"k8s.io/apimachinery/pkg/runtime"
)
func New(obj runtime.Object, action string) Event {
meta, err := meta.Accessor(obj)
if err != nil {
panic(fmt.Sprintf("Object has no meta? %s", err)
}
namespace := meta.GetNamespace()
name := meta.GetName()
kind := strings.ToLower(obj.GetObjectKind().GroupVersionKind().Kind)
reason := action
status := m[action]
// .. then do something like the current typeswitch that *just* sets host+component
}There was a problem hiding this comment.
Thanks Gus. That duplicated codes have been there for a year since I had limited knowledge about k8s. Will update it!
| } | ||
|
|
||
| logrus.Fatal(http.ListenAndServe(":8081", nil)) | ||
| //if conf.Resource.Services { |
| } | ||
|
|
||
| // | ||
| //func watchServices(client *client.Client, eventHandler handlers.Handler) cache.Store { |
There was a problem hiding this comment.
There will be separate controller for each resource. I only use one for Pod in this PR mostly for showing use-case for the 2nd part of the blogpost. I will cover the rest in another PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.