Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Allow plugins to specify a custom icon #1422

Closed
scothis opened this issue Sep 28, 2020 · 1 comment · Fixed by #2786
Closed

Allow plugins to specify a custom icon #1422

scothis opened this issue Sep 28, 2020 · 1 comment · Fixed by #2786
Assignees
Labels
api enhancement New feature or request plugin ui
Projects

Comments

@scothis
Copy link
Contributor

scothis commented Sep 28, 2020

Describe the problem/challenge you have

Clarity has a nice generic set of computing related icons, but the odds of Clarity having an icon appropriate for a plugin, which are often tied to a specific project, is unlikely.

Describe the solution you'd like

Plugins should be able to define a custom navigation icon. For example, a Knative plugin should use the Knative logo, and not a generic cloud icon.

Anything else you would like to add:

Data URIs are a good way to avoid plugins needing to reference external assets. To aid theming and visual consistency, a single SVG stroke could be allowed that is then styled by the client to match the current theme.

@wwitzel3 wwitzel3 added api plugin ui enhancement New feature or request labels Sep 28, 2020
@wwitzel3 wwitzel3 added this to Incoming in Plugins Dec 15, 2020
@ftovaro
Copy link
Contributor

ftovaro commented Aug 10, 2021

I can take a look at this one, If I require more info I'll be posting it here

@wwitzel3 wwitzel3 added this to To do in 0.24 via automation Aug 11, 2021
@wwitzel3 wwitzel3 removed this from Incoming in Plugins Aug 11, 2021
@karayim karayim moved this from To do to In progress in 0.24 Aug 12, 2021
xtreme-vikram-yadav pushed a commit to ftovaro/octant that referenced this issue Sep 1, 2021
- Show default icon when svg is invalid
- Show console error when svg in invalid

Signed-off-by: Vikram Yadav <yvikram@vmware.com>
vmware-archive#1422
@xtreme-vikram-yadav xtreme-vikram-yadav moved this from In progress to Review in progress in 0.24 Sep 2, 2021
0.24 automation moved this from Review in progress to Done Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api enhancement New feature or request plugin ui
Projects
No open projects
0.24
Done
Development

Successfully merging a pull request may close this issue.

3 participants