use options.KubeConfig to check if loading API is needed

[wwitzel3]

Signed-off-by: Wayne Witzel III wayne@riotousliving.com

Which issue(s) this PR fixes

• Fixes kubeconfig flag not working in 0.14 #1128
• Fixes prompted to enter kubeconfig even though I provided one #1129

[mklanjsek]

Tested on my machine and it works well (note: I was also not able to repro the issue on my machine before the fix).

Notice that when I remove current-context field from bubeconfig file, Octant fails to start with this:

unable to start runner: failed to start service api: failed to init cluster client: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

Since that used to make Octant show the Add a new kubeconfig popup, I thing this is much better than before (and as Wayne just pointed out to me, kubectl fails in that case too).

[wwitzel3]

Tested on my machine and it works well (note: I was also not able to repro the issue on my machine before the fix).

Notice that when I remove current-context field from bubeconfig file, Octant fails to start with this:

unable to start runner: failed to start service api: failed to init cluster client: invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

Since that used to make Octant show the Add a new kubeconfig popup, I thing this is much better than before (and as Wayne just pointed out to me, kubectl fails in that case too).

I extended our error message to hint at checking the current-context

[GuessWhoSamFoo]

Testing various ways to provide a kubeconfig (command line flag, environment variable, manual input through UI) will be need be expanded upon from the e2e proposal in #810