This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
regression: find the correct custom resource version #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates Octant to allow it to be able to detect the extact custom resource version to load when generating content. Previously, it used the first version which could be incorrect. This change also: * extracts custom resource loading to a new interface * ensures the CRD is valid when trying to find the GVK for a CRD * adds helpers to make generating CRD/CR easier Signed-off-by: bryanl <bryanliles@gmail.com>
bryanl
force-pushed
the
find-proper-crd-version
branch
from
6b8a634
to
c085949
Compare
wwitzel3
approved these changes
Aug 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change updates Octant to allow it to be able to detect the exact custom resource version to load when generating content. Previously, it used the first version which could be incorrect.
This change also:
Release note: