This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Remove height from FlexLayoutSection #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GuessWhoSamFoo <foos@vmware.com>
GuessWhoSamFoo
force-pushed
the
issue-1156
branch
from
a6b9cbc
to
13d1218
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR removes height and margin from FlexLayoutSection. It had only once use case where donut charts were resized for the detail view over a resource viewer. Instead, this takes the donut chart size which was previously unused and passes those values as height/width dimensions for the resulting svg instead.
We should also see modest performance gains as
sectionStylewill no longer run each second.Which issue(s) this PR fixes