Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Update to electron 13 and node 16 #2898

Merged

Conversation

GuessWhoSamFoo
Copy link
Contributor

@GuessWhoSamFoo GuessWhoSamFoo commented Sep 20, 2021

What this PR does / why we need it:
Since the peer dependency requirements in angular and electron-builder now supports node 16, we can now use a single node version.

Special notes for your reviewer:
sindresorhus/electron-store#146 - electron-store is pinned to 5.2.0 due to a private label and prevents the move to future electron versions unless: a different store is used, conf is updated (which seems to have community support), or remained pinned to electron 13 before the remote module is removed.

> octant@0.24.0 build-electron
> npx tsc main.ts && npm run build -- --base-href ./

node_modules/conf/dist/source/index.d.ts:5:5 - error TS18028: Private identifiers are only available when targeting ECMAScript 2015 and higher.

5     #private;
      ~~~~~~~~

Signed-off-by: GuessWhoSamFoo foos@vmware.com

Signed-off-by: GuessWhoSamFoo <foos@vmware.com>
@wwitzel3 wwitzel3 added this to In progress in 0.25 via automation Sep 21, 2021
0.25 automation moved this from In progress to Reviewer approved Sep 21, 2021
@GuessWhoSamFoo GuessWhoSamFoo merged commit 4464068 into vmware-archive:master Sep 21, 2021
0.25 automation moved this from Reviewer approved to Done Sep 21, 2021
@GuessWhoSamFoo GuessWhoSamFoo deleted the electron-13-and-node-16 branch September 21, 2021 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
0.25
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants