This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
List additional columns in Custom Resource view #473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Custom Resource Definitions may additionalPrinterColumns that are specific to a give api version. The CustomResourceHandler and CustomResourceListHandler were only handling top-level additionalPrinterColumns that apply to all columns regardless of version. This change handles version-specific additionalPrinterColumns. This change addresses vmware-archive#405 Signed-off-by: Gary Smith <garysmith123@gmail.com>
GarySmith
force-pushed
the
additionalPrinterColumns
branch
from
acc936e
to
c9843e3
Compare
|
Note that this is failing the unit test due to an unrelated bug in the internal representation of CRDs in octant, discussed here #405 (comment) . Wayne Witzel suggested in the octant slack channel that this is being addressed in another PR. |
|
Hello, I'm going to close this PR because I want to fix a bigger problem around CRDs that will make this change redundant. Thanks for pointing this issue out, and we'll have a fix pretty soon. |
|
I revamped the CRD system in #490. Should solve this problem and a couple of others. Please retest when you get a chance. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom Resource Definitions may additionalPrinterColumns that are
specific to a give api version. The CustomResourceHandler and
CustomResourceListHandler were only handling top-level
additionalPrinterColumns that apply to all columns regardless of
version. This change handles version-specific additionalPrinterColumns.
This change addresses #405