Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Create objects using store #803

Merged
merged 1 commit into from
Apr 1, 2020
Merged

Create objects using store #803

merged 1 commit into from
Apr 1, 2020

Conversation

bryanl
Copy link
Contributor

@bryanl bryanl commented Mar 30, 2020

Signed-off-by: bryanl bryanliles@gmail.com

What this PR does / why we need it:

This change does the following:

  • Add Create function to store
  • Add Create support to plugin api

Which issue(s) this PR fixes

Special notes for your reviewer:

Release note:

Add support for creating objects

This change does the following:

* Add Create function to store
* Add Create support to plugin api

Signed-off-by: bryanl <bryanliles@gmail.com>
@GuessWhoSamFoo
Copy link
Contributor

This PR will resolve #599

@bryanl bryanl self-assigned this Mar 30, 2020
@wwitzel3
Copy link
Contributor

wwitzel3 commented Apr 1, 2020

I'm taking a look at this now.

@wwitzel3
Copy link
Contributor

wwitzel3 commented Apr 1, 2020

@bryanl Do we want to have an alert for success/failure on this one? Right now things just kind of silently work/fail.

@bryanl bryanl merged commit 6c445a9 into master Apr 1, 2020
@bryanl bryanl deleted the store-create branch April 1, 2020 16:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Octant should be able to create objects
3 participants