Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Decrease link latency #854

Merged
merged 1 commit into from Apr 21, 2020
Merged

Decrease link latency #854

merged 1 commit into from Apr 21, 2020

Conversation

bryanl
Copy link
Contributor

@bryanl bryanl commented Apr 21, 2020

What this PR does / why we need it:

This change does the following:

  • stops Angular from reloading the whole page when clicking links
  • reuses content component when navigating between tabs
  • removes superfluous navigation when content path changes
  • attempts to be smarter about detecting content path changes

Release note:

Decrease latency when clicking on links

This change does the following:
* stops Angular from reloading the whole page when clicking links
* reuses content component when navigating between tabs
* removes superfluous navigation when content path changes
* attempts to be smarter about detecting content path changes

Signed-off-by: bryanl <bryanliles@gmail.com>
@bryanl bryanl self-assigned this Apr 21, 2020
Copy link
Contributor

@wwitzel3 wwitzel3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. I'm seeing a 15% decrease (avg. -50ms) in UI load times when switching between views vs. current master according to dev tools.

@bryanl bryanl merged commit 28cc357 into master Apr 21, 2020
@GuessWhoSamFoo GuessWhoSamFoo deleted the link-latency branch April 22, 2020 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants