This repository has been archived by the owner on Mar 24, 2022. It is now read-only.
tlsscan: respect timeout if TLS handshake hangs #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up until this commit the context supplied during the scan only applied to the initial dial of the connection. It is my suspicion that there are some servers which will not close the connection if given something they do not expect (a TLS handshake). We should be good citizens anyway and not depend on servers having that behavior in the first place. [fixes #153764270]
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until this commit the context supplied during the scan only applied
to the initial dial of the connection. It is my suspicion that there are
some servers which will not close the connection if given something they
do not expect (a TLS handshake).
We should be good citizens anyway and not depend on servers having that
behavior in the first place.
[fixes #153764270]