This repository has been archived by the owner on Jan 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Broken resource returned twice to the pool #15
Comments
mballoni, Yes, this needs to be handled properly. Please create a PR and we will take a look at it for merging. Thank you. |
Great, working on it. Also, would you mind if I update the Jedis version? Thank you. |
Doing some integration tests right now, but you already can see the changes at the last three commits right here at my fork: |
PR opened: |
PR merged. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Making some crash tests I noted that broken resources are returned twice to the pool:
https://github.com/pivotalsoftware/session-managers/blob/master/redis-store/src/main/java/com/gopivotal/manager/redis/JedisTemplate.java#L42
Checking the jedis docs I came across this issue that explains the problem as well as the solution description:
redis/jedis#476
Do you agree with this issue? I only ask because the tests requires it to be returned twice (one broken and one "normal").
I would gladly make a pull request to fix this, can I? I just checked the contribution guidelines.
The text was updated successfully, but these errors were encountered: