Skip to content
This repository has been archived by the owner on Jan 8, 2021. It is now read-only.

Broken resource returned twice to the pool #15

Closed
mballoni opened this issue Feb 21, 2017 · 5 comments
Closed

Broken resource returned twice to the pool #15

mballoni opened this issue Feb 21, 2017 · 5 comments

Comments

@mballoni
Copy link
Contributor

Making some crash tests I noted that broken resources are returned twice to the pool:
https://github.com/pivotalsoftware/session-managers/blob/master/redis-store/src/main/java/com/gopivotal/manager/redis/JedisTemplate.java#L42

Checking the jedis docs I came across this issue that explains the problem as well as the solution description:
redis/jedis#476

Do you agree with this issue? I only ask because the tests requires it to be returned twice (one broken and one "normal").

I would gladly make a pull request to fix this, can I? I just checked the contribution guidelines.

@jkonicki
Copy link
Contributor

mballoni,

Yes, this needs to be handled properly. Please create a PR and we will take a look at it for merging.

Thank you.

@mballoni
Copy link
Contributor Author

Great, working on it.

Also, would you mind if I update the Jedis version?
It would be great to use some new features such as the java 7 auto closable try-with-resources.

Thank you.

@mballoni
Copy link
Contributor Author

mballoni commented Feb 22, 2017

Doing some integration tests right now, but you already can see the changes at the last three commits right here at my fork:

https://github.com/mballoni/session-managers/commits/master

@mballoni
Copy link
Contributor Author

PR opened:
#17

@mballoni
Copy link
Contributor Author

PR merged. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants