This repository has been archived by the owner on May 14, 2020. It is now read-only.
Added org_id as a required parameter in terraform schema #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saloneerege
changed the title
shylasrinivas
approved these changes
Feb 26, 2020
| @@ -46,4 +46,7 @@ func testAccPreCheck(t *testing.T) { | |||
| if v := os.Getenv("TEST_SDDC_ID"); v == "" { | |||
| t.Fatal("TEST_SDDC_ID must be set for acceptance tests") | |||
| } | |||
| if v := os.Getenv("AWS_ACCOUNT_NUMBER"); v == "" { | |||
There was a problem hiding this comment.
Is this test needed? We don't want to enforce users to provide account number since it is optional - if account number is not provided, we return a list of all accounts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org_id has been now made a required parameter in terraform. This value is now a part of the ConnectorWrapper struct. All data sources and resources can use the value from connector wrapper.