This repository has been archived by the owner on May 10, 2024. It is now read-only.
vmcheck: allow ignoring iopl errors #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an hotfix which does not completely fix the reported bug, but it alleviates the symptoms in most cases. See #20 (comment) for all the details. |
lucab
force-pushed
the
ups/opportunistic-iopl
branch
from
cbc8d87
to
f4349af
Compare
|
Hi @lucab, I know this is coming a bit late, but if you're still interested in this PR, could you rebase it on top of the recent changes? thanks! |
lucab
force-pushed
the
ups/opportunistic-iopl
branch
from
f4349af
to
7a27081
Compare
|
@frapposelli no problem, rebased. |
This introduces an additional flag for the VM-checking logic, in order to allow consuming applications to keep going when changing I/O access level is not alloewd (see `kernel_lockdown(7)` on Linux). In most cases the library may work without higher I/O level, and actual failures can be handled via normal error-handling on RPC methods. Signed-off-by: Luca BRUNO <luca.bruno@coreos.com>
lucab
force-pushed
the
ups/opportunistic-iopl
branch
from
7a27081
to
f0f5405
Compare
|
@frapposelli ping, any chance to have this reviewed and merged? |
|
@lucab sorry, this fell through the cracks. Merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an additional flag for the VM-checking logic,
in order to allow consuming applications to keep going when changing
I/O access level is not alloewd (see
kernel_lockdown(7)on Linux).In most cases the library may work without higher I/O level,
and actual failures can be handled via normal error-handling on RPC
methods.
Ref: #20