Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Commit

Permalink
Minor fix for #817 - missing parentheses (#924)
Browse files Browse the repository at this point in the history
Fixes #817

Without this change:
```
root@Photon-1 [ ~ ]# docker volume create -d vmdk --name=v1@bad
Error response from daemon: create v1@bad: VolumeDriver.Create: Server returned an error: TypeError('can only join an iterable',)
```

After this change:
```
root@Photon-1 [ ~ ]# docker volume create -d vmdk --name=v1@bad
Error response from daemon: create v1@bad: VolumeDriver.Create: Invalid datastore 'bad'.
Known datastores: datastore1, datastore2.
Default datastore: datastore1
```
  • Loading branch information
pdhamdhere committed Feb 17, 2017
1 parent e7acd33 commit 477d478
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions esx_service/vmdk_ops.py
Expand Up @@ -245,7 +245,7 @@ def cloneVMDK(vm_name, vmdk_path, opts={}, vm_uuid=None, vm_datastore=None):
return err("Invalid datastore '%s'.\n" \
"Known datastores: %s.\n" \
"Default datastore: %s" \
% (src_datastore, ", ".join(get_datastore_names_list), vm_datastore))
% (src_datastore, ", ".join(get_datastore_names_list()), vm_datastore))

error_info, tenant_uuid, tenant_name = auth.authorize(vm_uuid,
src_datastore, auth.CMD_ATTACH, {})
Expand Down Expand Up @@ -742,7 +742,7 @@ def executeRequest(vm_uuid, vm_name, config_path, cmd, full_vol_name, opts):
return err("Invalid datastore '%s'.\n" \
"Known datastores: %s.\n" \
"Default datastore: %s" \
% (datastore, ", ".join(get_datastore_names_list), vm_datastore))
% (datastore, ", ".join(get_datastore_names_list()), vm_datastore))

error_info, tenant_uuid, tenant_name = auth.authorize(vm_uuid, datastore, cmd, opts)
if error_info:
Expand Down

0 comments on commit 477d478

Please sign in to comment.