Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Check that vm-open-tools are installed #207

Closed
msterin opened this issue Mar 25, 2016 · 7 comments
Closed

Check that vm-open-tools are installed #207

msterin opened this issue Mar 25, 2016 · 7 comments

Comments

@msterin
Copy link
Contributor

msterin commented Mar 25, 2016

Summary:
need to check that either vm-open-tools or vmware-tools (or just vmci kernel module) are installed

Details:
The code works only if the Linux VM (running Docker) is running under ESX and vm-open-tools or vmware-tools are installed. If they are not, some mystery bugs will be reported.
Plugin GO code needs to check that the vm-open-tools or vmware-tools are installed, and that it is indeed ESX VM (we can see it in BIOS). This will simplify troubleshooting and accelerated solving customer install issues.

As an alternative, we can write a "check-prerequisites" script thst does all that and (eventually) more.

@msterin msterin added this to the v1 GA milestone Mar 25, 2016
@msterin msterin modified the milestones: TP, v1 GA Apr 12, 2016
@msterin
Copy link
Contributor Author

msterin commented Apr 12, 2016

I believe can be a big issues if we silently do not work if cm-open-tools is not installed. We absolutely should do a simple check and at least print an error message IMO.

@kerneltime
Copy link
Contributor

One option is to add the dependency to rpm and deb to check for vm tools being installed.

@msterin
Copy link
Contributor Author

msterin commented Apr 22, 2016

that would be very good. However there are "Vmware tools" (no rpm package) and open-vm-tools. Can you put dependency on presence of a kernel module (lsmod | grep vmw_vmci) ?

@msterin
Copy link
Contributor Author

msterin commented Apr 29, 2016

NOTE: this obviously includes test and doc if needed, so closing #268 as dup

@pdhamdhere
Copy link
Contributor

Document for TP and add code level dependency for Beta.

@kerneltime
Copy link
Contributor

kerneltime commented Jun 10, 2016

There are complications for checking VMCI.

  • It can be installed in more than one ways. (open vm tools, VMware tools, built into the kernel)
  • It is not always loaded as loadable modules. (Photon)
  • Installed does not imply running vmci communication (I have a box where vsock is loaded but does not work since tools are not installed in it's entirety)
    At a minimum when we discover communication failures we should log the possible reasons.

Thus, adding pre installation checks are both complex and not sufficient. Run time checks equate to calling the VMCI code and getting a failure. Thus, logging has been enhanced to help outline the possible reasons.

@kerneltime
Copy link
Contributor

#452 will address the logging requirements.

kerneltime pushed a commit that referenced this issue Jun 10, 2016
Since the cause of communication failures need more info than what can be packed into a log message. Forward the customer to the FAQ.

2016-06-11 00:15:06.869406637 +0530 IST [WARNING] 'list' failed: connection reset by peer (errno=104). Hit communication issue with ESX (vmci or ESX service)
 Please refer FAQ https://github.com/vmware/docker-volume-vsphere/wiki#faq
kerneltime added a commit that referenced this issue Jun 10, 2016
Add additional logging for vmci failures. Fixes #207
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants