Skip to content
This repository has been archived by the owner on Nov 9, 2020. It is now read-only.

Fixed request options init for create op. #1636

Merged
merged 1 commit into from Jul 27, 2017
Merged

Conversation

govint
Copy link
Contributor

@govint govint commented Jul 26, 2017

Verified via the command line posted in the issue,

root@photon-machine [ /vol/vpl-dv/docker-volume-vsphere ]# docker run -it --volume-driver=vsphere -v debugvol14@sharedVmfs-0:/v1 --name=abc busybox
/ #

@lipingxue
Copy link
Contributor

@govint So this bug only exist in photon_driver code, right?
In #1615, you said that, fix from docker side is needed. Please file an issue against docker and put the link in issue #1615.

Copy link
Contributor

@lipingxue lipingxue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@govint
Copy link
Contributor Author

govint commented Jul 26, 2017

@lipingxue, no, there is a bug in the vmdk and photon driver as well which is seen from 0.16 onwards. The docker side of the issue is a separate part and I'll raise that. This change fixes the issue in the plugin code.

Copy link
Contributor

@shaominchen shaominchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@govint govint merged commit 4de33cf into master Jul 27, 2017
@govint govint deleted the init-request-options branch July 27, 2017 03:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants