-
Notifications
You must be signed in to change notification settings - Fork 95
Add document about releases for GA and post GA [SKIP CI]. #1843
Add document about releases for GA and post GA [SKIP CI]. #1843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A few nits/typos below.
CONTRIBUTING.md
Outdated
|
||
edge release: will be released every month for users who want a drop of latest. | ||
|
||
stable release: will be release every 3 month for users who want to a stable version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to => want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
CONTRIBUTING.md
Outdated
|
||
### Nomenclature for release: | ||
|
||
The Nomenclature for release will follow the format ```major-version. minor-version.build-version.release-type```. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the redundant space after "major-version."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CONTRIBUTING.md
Outdated
|
||
The Nomenclature for release will follow the format ```major-version. minor-version.build-version.release-type```. | ||
|
||
“Major-Version” will be the major version number, “minor-version” will be the minor version number which will be bumped on each monthly release. “build-version” by default is 0. If we decide to cut one more release on that month (maybe some patch releases), we can increase the “build-version” by 1 for that release. “release-type” has two possible values: “stable” to mark a stable release and “edge” to mark a edge release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- will be bumped on each monthly release => will be bumped up for each monthly release
- on that month => in that month
- a edge => an edge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
CONTRIBUTING.md
Outdated
|
||
“Major-Version” will be the major version number, “minor-version” will be the minor version number which will be bumped on each monthly release. “build-version” by default is 0. If we decide to cut one more release on that month (maybe some patch releases), we can increase the “build-version” by 1 for that release. “release-type” has two possible values: “stable” to mark a stable release and “edge” to mark a edge release. | ||
|
||
For Example, assume we plan to cut the first release for GA on August , the release number will be “1.0.0.stable”. Then the monthly edge release on September will be “1.1.0.edge”, the monthly release on October will be “1.2.0.edge” and the stable release on November will be “1.3.0.stable”, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- on August/September/October/November => in August/...
- Remove the redundant space after "August"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/user-guide/faq.md
Outdated
|
||
edge release: will be released every month for users who want a drop of latest. | ||
|
||
stable release: will be release every 3 month for users who want to a stable version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
want to => want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
CONTRIBUTING.md
Outdated
@@ -277,6 +277,24 @@ COVERAGE_PROCESS_START DEFAULT=/coverage.rc | |||
|
|||
The CI/CD system is based on [Drone platform](https://drone.io/) and the server is https://ci.vmware.run/. More information is found at our [CI.md](https://github.com/vmware/docker-volume-vsphere/blob/master/CI.md) | |||
|
|||
## Releases for GA and post GA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "vDVS release naming convention" or "Release naming convention"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
CONTRIBUTING.md
Outdated
@@ -277,6 +277,24 @@ COVERAGE_PROCESS_START DEFAULT=/coverage.rc | |||
|
|||
The CI/CD system is based on [Drone platform](https://drone.io/) and the server is https://ci.vmware.run/. More information is found at our [CI.md](https://github.com/vmware/docker-volume-vsphere/blob/master/CI.md) | |||
|
|||
## Releases for GA and post GA | |||
The following is the plan for releases for GA and post GA. Before GA, the release name format remains the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we should call out GA/Post GA, there will be a question from customer side about GA date.
/CC @tusharnt
CONTRIBUTING.md
Outdated
### Type of Release: | ||
We plan to have two types of releases: edge release and stable release. | ||
|
||
edge release: will be released every month for users who want a drop of latest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edge => Edge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
CONTRIBUTING.md
Outdated
|
||
edge release: will be released every month for users who want a drop of latest. | ||
|
||
stable release: will be release every 3 month for users who want to a stable version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stable => Stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
CONTRIBUTING.md
Outdated
|
||
### Nomenclature for release: | ||
|
||
The Nomenclature for release will follow the format ```major-version. minor-version.build-version.release-type```. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Nomenclature => The nomenclature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/user-guide/faq.md
Outdated
### Which release I should use? | ||
You can choose release based on your needs. There will be two types of releases: edge release and stable release. | ||
|
||
edge release: will be released every month for users who want a drop of latest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
CONTRIBUTING.md
Outdated
|
||
edge release: will be released every month for users who want a drop of latest. | ||
|
||
stable release: will be release every 3 month for users who want to a stable version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be release >> will be released ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@@ -19,6 +19,15 @@ This can be achieved via [Tenancy](http://vmware.github.io/docker-volume-vsphere | |||
### Can I migrate data between Linux and Windows containers? | |||
Volumes created via the Linux plugin are formatted with ext4 by default, and the ones created via the Windows plugin are formatted with NTFS. While it is possible to cross-mount such volumes, the vSphere Storage for Docker plugin doesn't support such cases, nor does it provide any explicit help. | |||
|
|||
### Which release I should use? | |||
You can choose release based on your needs. There will be two types of releases: edge release and stable release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about this?
Edge release: A monthly release with new features and bug fixes
Stable release: A quarterly release with reliable/stable updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
docs/user-guide/faq.md
Outdated
|
||
stable release: will be release every 3 month for users who want to a stable version. | ||
|
||
For details about the nomenclature for release, please refer [here](/CONTRIBUTING.md/#releases-for-ga-and-post-ga). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this?
Please refer release convention for more details.
need to supply fully qualified link, I don't think public facing document will resolve /CONTRIBUTING.md/#re
path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
CONTRIBUTING.md
Outdated
|
||
The Nomenclature for release will follow the format ```major-version. minor-version.build-version.release-type```. | ||
|
||
“Major-Version” will be the major version number, “minor-version” will be the minor version number which will be bumped on each monthly release. “build-version” by default is 0. If we decide to cut one more release on that month (maybe some patch releases), we can increase the “build-version” by 1 for that release. “release-type” has two possible values: “stable” to mark a stable release and “edge” to mark a edge release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major-Version” will be the major version number
:)
can you please elaborate more about major version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@shaominchen @shuklanirdesh82 @ashahi1 I have addressed your comments. |
CONTRIBUTING.md
Outdated
@@ -277,6 +277,24 @@ COVERAGE_PROCESS_START DEFAULT=/coverage.rc | |||
|
|||
The CI/CD system is based on [Drone platform](https://drone.io/) and the server is https://ci.vmware.run/. More information is found at our [CI.md](https://github.com/vmware/docker-volume-vsphere/blob/master/CI.md) | |||
|
|||
## Release naming convention | |||
The following is the plan for releases for GA and post GA. Before GA, the release name format remains the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to reword as below:
The following is the plan for GA and post GA releases. Before GA, the release name format remains the same e.g. 0.XX (existing release tag)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
We plan to have two types of releases: edge release and stable release. | ||
|
||
Edge release: A monthly release with new features and bug fixes. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: no need for extra line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That line is needed, otherwise, the line "edge release" and "stable release" will be in the same line when browsing the md file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it. Thanks for checking!
You can choose release based on your needs. There will be two types of releases: edge release and stable release. | ||
|
||
Edge release: A monthly release with new features and bug fixes. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same.
docs/user-guide/faq.md
Outdated
|
||
Stable release: A quarterly release with reliable/stable updates. | ||
|
||
For details about the nomenclature for release, please refer [here](https://github.com/vmware/docker-volume-vsphere/blob/master/CONTRIBUTING.md#release-naming-convention). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please reword this as shown below:
Please refer [release convention](https://github.com/vmware/docker-volume-vsphere/blob/master/CONTRIBUTING.md#release-naming-convention) for more details.
View: Please refer release convention for more details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@shuklanirdesh82 Could you review it? |
@lipingxue I am waiting for the comments to be addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for having patience and addressing comments.
Please resolve conflict before merging your change.
Add documment about releases for GA and post GA. Minor fix to fix the link. Minor fix.
bd8c861
to
7dcdf87
Compare
Fixed #1797