This repository has been archived by the owner on Mar 2, 2022. It is now read-only.
Make the python preinstall more DRY #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtracey
force-pushed
the
python-install
branch
from
edfddf5
to
18fdaae
Compare
stevesloka
suggested changes
Oct 10, 2018
There was a problem hiding this comment.
When running I get this error in vagrant up:
TASK [Gathering Facts] *********************************************************
fatal: [xenial]: FAILED! => {"changed": false, "module_stderr": "Shared connection to 127.0.0.1 closed.\r\n", "module_stdout": "/bin/sh: 1: /usr/bin/python: not found\r\n", "msg": "MODULE FAILURE", "rc": 0}
to retry,
|
The above error might be my mac with python3, I'm checking into that now. |
scottslowe
suggested changes
Oct 11, 2018
There was a problem hiding this comment.
These changes failed off the bat when attempting to build an AWS image. Here's the output from Packer:
==> ami-ubuntu: Executing Ansible: ansible-playbook --extra-vars packer_build_name=ami-ubuntu packer_builder_type=amazon-ebs -i /tmp/packer-provisioner-ansible384605225 /home/slowe/Public/Repos/heptio/labs/wardroom/ansible/playbook.yml -e ansible_ssh_private_key_file=/tmp/ansible-key961563506 --extra-vars common_upgrade_base=true kubernetes_version=1.11.3-00 kubernetes_cni_version=0.6.0-00
ami-ubuntu:
ami-ubuntu: PLAY [all] *********************************************************************
ami-ubuntu:
ami-ubuntu: TASK [install python] **********************************************************
ami-ubuntu: changed: [default]
ami-ubuntu:
ami-ubuntu: PLAY [build image] *************************************************************
ami-ubuntu:
ami-ubuntu: TASK [Gathering Facts] *********************************************************
ami-ubuntu: fatal: [default]: FAILED! => {"changed": false, "module_stderr": "/bin/sh: 1: /usr/bin/python: not found\nConnection to 127.0.0.1 closed.\r\n", "module_stdout": "", "msg": "MODULE FAILURE", "rc": 127}
ami-ubuntu: to retry, use: --limit @/home/slowe/Public/Repos/heptio/labs/wardroom/ansible/playbook.retry
ami-ubuntu:
ami-ubuntu: PLAY RECAP *********************************************************************
ami-ubuntu: default : ok=1 changed=1 unreachable=0 failed=1
ami-ubuntu:
Right now we have the same code for installing python in two different places. Additionally, this code assumes Debian based systems. So, clean this up so that it only applies to Debian systems, and such that it is consolidated in `pre.yml` Signed-off-by: Craig Tracey <craigtracey@gmail.com>
craigtracey
force-pushed
the
python-install
branch
from
18fdaae
to
a30f7d6
Compare
|
Yeah, I borked the logic here. Updated. Please take a look @stevesloka @scottslowe |
|
Tested w/ Ubuntu and CentOS builds on AWS, no issues and resulting images had Python 2 installed and working as expected. LGTM. |
scottslowe
approved these changes
Oct 15, 2018
stevesloka
approved these changes
Oct 15, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have the same code for installing python in two different
places. Additionally, this code assumes Debian based systems. So, clean
this up so that it only applies to Debian systems, and such that it is
consolidated in
pre.ymlSigned-off-by: Craig Tracey craigtracey@gmail.com