INT-657: Istio helm chart support for K8s v1.17 #103
Conversation
|
@gangadharaswamy, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
Change lgtm. For new release please change references to |
| [WAVEFRONTADAPTERFORISTIO014GAMS080520] |
There was a problem hiding this comment.
nit: Modify this to be "WAVEFRONTADAPTERFORISTIO015GAMS080520"
"015" instead of "014"
README.md
Outdated
| $ curl -LO https://raw.githubusercontent.com/vmware/wavefront-adapter-for-istio/0.1.5/install/config.yaml | ||
| ``` | ||
|
|
||
| For Kubernetes v1.15.0 to v1.16.x |
There was a problem hiding this comment.
so apps/v1 doesn't work for k8s versions 1.15 and 1.16 ?
According to https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/ :
"Deployment in the extensions/v1beta1, apps/v1beta1, and apps/v1beta2 API versions is no longer served
Migrate to use the apps/v1 API version, available since v1.9. Existing persisted data can be retrieved/updated via the new version."
We should just be able to use "apps/v1" across any k8s version. Could you double check.
|
@gangadharaswamy, VMware has approved your signed contributor license agreement. |
Description
The Istio deployment apiVersion is updated to
apps/v1the Chart version is bumped up
And also minor changes to README
Additional context
Fixes INT-657, INT-727(Duplicate of INT-657) and #92