Skip to content

Commit

Permalink
fix: breaking changes for core in v6
Browse files Browse the repository at this point in the history
Deprecating code that no-longer will be ship with v6 when relesed. This
include things like:

  - focus-trap
  - button-inline

Signed-off-by: Bozhidar Dryanovski <bozhidar.dryanovski@gmail.com>
  • Loading branch information
bdryanovski committed Jan 11, 2022
1 parent e3d62a7 commit 19d1ca4
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 713 deletions.
6 changes: 0 additions & 6 deletions packages/core/src/button-inline/button-inline.element.ts
Expand Up @@ -49,9 +49,3 @@ export class CdsButtonInline extends CdsBaseButton {
return [baseStyles, styles];
}
}

/**
* @deprecated
* renamed to `cds-button-inline` in 6.0 to align to rest of the `cds-button-*` APIs
*/
export class CdsInlineButton extends CdsButtonInline {}
11 changes: 1 addition & 10 deletions packages/core/src/button-inline/register.ts
Expand Up @@ -5,7 +5,7 @@
*/

import { registerElementSafely } from '@cds/core/internal';
import { CdsButtonInline, CdsInlineButton } from './button-inline.element.js';
import { CdsButtonInline } from './button-inline.element.js';

registerElementSafely('cds-button-inline', CdsButtonInline);

Expand All @@ -14,12 +14,3 @@ declare global {
'cds-button-inline': CdsButtonInline;
}
}

/** @deprecated */
registerElementSafely('cds-inline-button', CdsInlineButton);

declare global {
interface HTMLElementTagNameMap {
'cds-inline-button': CdsInlineButton;
}
}
1 change: 0 additions & 1 deletion packages/core/src/internal/index.ts
Expand Up @@ -47,7 +47,6 @@ export * from './services/keycodes.service.js';
export * from './utils/conditional.js';
export * from './utils/enum.js';
export * from './utils/exists.js';
export * from './utils/focus-trap.js';
export * from './utils/framework.js';
export * from './i18n/utils.js';
export * from './positioning/utils.js';
Expand Down

0 comments on commit 19d1ca4

Please sign in to comment.