Skip to content

Commit

Permalink
fix(core:card): alignment in grid layout
Browse files Browse the repository at this point in the history
Fixes #6457

Signed-off-by: Ashley Ryan <asryan@vmware.com>
  • Loading branch information
Ashley Ryan authored and ashleyryan committed Dec 20, 2021
1 parent ca8e299 commit 52d2063
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 8 deletions.
8 changes: 0 additions & 8 deletions packages/core/src/card/card.element.scss
@@ -1,8 +1,6 @@
@import './../styles/tokens/generated/index';

:host {
--width: fit-content;
--height: auto;
--padding: var(--cds-global-space-6) var(--cds-global-space-8);

--background: #{$cds-alias-object-container-background};
Expand All @@ -12,9 +10,3 @@

--card-remove-margin: var(--cds-global-space-8);
}

@supports (-moz-appearance: none) {
:host {
--width: -moz-fit-content;
}
}
37 changes: 37 additions & 0 deletions packages/core/src/card/card.stories.ts
Expand Up @@ -385,3 +385,40 @@ export function WithLayoutAndOverflow() {
</div>
</cds-card>`;
}

export function WithinGrid() {
return html`<div cds-layout="grid gap:md cols:6 align:stretch">
<cds-card aria-labelledby="gridCard1">
<h3 id="gridCard1" cds-text="section" cds-layout="p-y:sm">Card Title</h3>
<div cds-text="body light" cds-layout="p-y:md">
Card Content. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent volutpat tortor eget quam
auctor, quis sagittis libero auctor. Nulla augue ante, tincidunt sit amet semper vitae, tempus at ipsum.
Vestibulum elementum, turpis quis ullamcorper fermentum, elit turpis placerat ipsum, quis convallis ex nisi sit
amet lacus. Ut enim ipsum, tincidunt nec luctus id, pharetra id velit.
</div>
</cds-card>
<cds-card aria-labelledby="gridCard2">
<h3 id="gridCard2" cds-text="section" cds-layout="p-y:sm">Card Title</h3>
<div cds-text="body light" cds-layout="p-y:md">
Card Content.
</div>
</cds-card>
<cds-card aria-labelledby="gridCard3">
<h3 id="gridCard3" cds-text="section" cds-layout="p-y:sm">Card Title</h3>
<div cds-text="body light" cds-layout="p-y:md">
Card Content. Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent volutpat tortor eget quam
auctor, quis sagittis libero auctor.
</div>
</cds-card>
<cds-card aria-labelledby="gridCard4">
<h3 id="gridCard4" cds-text="section" cds-layout="p-y:sm">Card Title</h3>
<div cds-text="body light" cds-layout="p-y:md">
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent volutpat tortor eget quam auctor, quis
sagittis libero auctor. Nulla augue ante, tincidunt sit amet semper vitae, tempus at ipsum. Vestibulum
elementum, turpis quis ullamcorper fermentum, elit turpis placerat ipsum, quis convallis ex nisi sit amet lacus.
Ut enim ipsum, tincidunt nec luctus id, pharetra id velit. Aliquam nec elit ut neque lacinia mattis id ac lorem.
Vivamus egestas massa nulla, ac elementum purus pretium eu.
</div>
</cds-card>
</div>`;
}

0 comments on commit 52d2063

Please sign in to comment.