Skip to content

Commit

Permalink
fix: update colors (#307)
Browse files Browse the repository at this point in the history
## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] clarity.design website / infrastructure changes
- [ ] Other... Please describe:

## What is the current behavior?

- Token `--cds-global-color-construction-1100` is missing
- Token `--cds-global-color-yellow-1000` have value `hsl(40, 32%, 14%)`.
- Token `--cds-global-color-red-1000` have value `hsl(7, 10%, 17%)`.
- Token `--cds-global-color-red-900` have value `hsl(9, 100%, 22%)`.
- Token `--cds-global-color-jade-1000` have value `hsl(160, 69%, 19%)`.
- Token `--cds-global-color-jade-900` have value `hsl(160, 70%, 21%)`.
- Token `--cds-alias-utility-red (dark theme)` have value
`--cds-global-color-red-300`.

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-1848

## What is the new behavior?

- Token `--cds-global-color-construction-1100` have value `hsl(200, 31%,
13%)`.
- Token `--cds-global-color-yellow-1000` have value `hsl(40, 100%,
13%)`.
- Token `--cds-global-color-red-1000` have value `hsl(9, 100%, 22%)`.
- Token `--cds-global-color-red-900` have value `hsl(9, 100%, 28%)`.
- Token `--cds-global-color-jade-1000` have value `hsl(160, 69%, 14%)`.
- Token `--cds-global-color-jade-900` have value `hsl(160, 70%, 18%)`.
- Token `--cds-alias-utility-red (dark theme)` have value
`--cds-global-color-red-500`.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
  • Loading branch information
valentin-mladenov committed Apr 24, 2024
1 parent 74e7a6f commit 5c8b522
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
11 changes: 6 additions & 5 deletions projects/core/build/tokens.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ const color = {
600: token([9, 100, 59]),
700: token([9, 100, 44]),
800: token([9, 100, 38]),
900: token([9, 100, 22]),
1000: token([7, 10, 17]),
900: token([9, 100, 28]),
1000: token([9, 100, 22]),
},
ochre: {
50: token([41, 100, 96]),
Expand Down Expand Up @@ -182,8 +182,8 @@ const color = {
600: token([160, 69, 36]),
700: token([160, 64, 30]),
800: token([160, 100, 21]),
900: token([160, 70, 21]),
1000: token([160, 69, 19]),
900: token([160, 70, 18]),
1000: token([160, 69, 14]),
},
yellow: {
50: token([50, 100, 95]),
Expand All @@ -196,7 +196,7 @@ const color = {
700: token([40, 100, 37]),
800: token([40, 100, 26]),
900: token([40, 100, 18]),
1000: token([40, 32, 14]),
1000: token([40, 100, 13]),
},
lime: {
50: token([66, 100, 94]),
Expand Down Expand Up @@ -328,6 +328,7 @@ const color = {
800: token([198, 23, 23]),
900: token([198, 28, 18]),
1000: token([198, 30, 15]),
1100: token([200, 31, 13]),
},
gray: {
0: token([0, 0, 100]),
Expand Down
2 changes: 1 addition & 1 deletion projects/core/src/styles/theme.dark.scss
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@
--cds-alias-utility-yellow: #{$cds-global-color-ochre-400};
--cds-alias-utility-yellow-tint: #{$cds-global-color-ochre-900};
--cds-alias-utility-yellow-shade: #{$cds-global-color-ochre-300};
--cds-alias-utility-red: #{$cds-global-color-red-300};
--cds-alias-utility-red: #{$cds-global-color-red-500};
--cds-alias-utility-red-tint: #{$cds-global-color-red-1000};
--cds-alias-utility-red-shade: #{$cds-global-color-red-200};
--cds-alias-utility-tangerine: #{$cds-global-color-tangerine-600};
Expand Down

0 comments on commit 5c8b522

Please sign in to comment.