Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React: CdsModalHeaderActions uses the incorrect element name under the hood #107

Closed
4 of 7 tasks
ashleyryan opened this issue Jun 16, 2022 · 2 comments · Fixed by #108
Closed
4 of 7 tasks

React: CdsModalHeaderActions uses the incorrect element name under the hood #107

ashleyryan opened this issue Jun 16, 2022 · 2 comments · Fixed by #108
Assignees

Comments

@ashleyryan
Copy link
Contributor

Describe the bug

The component is producing an element that is cds-modal-header-action instead of cds-modal-header-actions . You can see the letter ‘s’ missing at the end of the created element. This causes the element to not be picked up and thus header actions do not appear at the slot they are supposed to be

How to reproduce

https://stackblitz.com/edit/clarity-react-8em3m2?file=src%2FApp.tsx,src%2Findex.html,src%2Findex.css

Expected behavior

Versions

Clarity project:

  • Clarity Core

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:
@ashleyryan ashleyryan self-assigned this Jun 16, 2022
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Jun 16, 2022
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Jun 16, 2022
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Jun 16, 2022
ashleyryan pushed a commit that referenced this issue Jun 17, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jul 6, 2022

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant