You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After the last release, related to PR #130, when set with disabled={false}, testing-library unit tests will fail if they have expect(pagination button).not.toBeDisabled()
Received element is disabled:
<cds-pagination-button action="last" aria-disabled="false" aria-label="go to last" cds-button-action="" disabled="false" role="button" shape="step-forward-2" tabindex="0" />
Expected behavior
The test should pass because the button is not disabled, but it's being rendered with disabled="false". This started happening after #130 with the change of the disabled attribute in the base button from a simple property to a getter/setter. Lit has a fix for this in the latest version of @lit-labs/react
Versions
Clarity project:
Clarity Core
Clarity Angular/UI
Clarity version:
v5.x
v6.x
Framework:
Angular
React
Vue
Other:
Framework version: ie: Angular 11
Device:
Type: [e.g. MacBook]
OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]
Additional notes
Add any other notes about the problem here.
The text was updated successfully, but these errors were encountered:
Fixesvmware-clarity#151
passing in a false value renders hidden="false" in the DOM, which is breaking the overlay layer logic
This is the boolean attribute issue that also effected modals as well
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.
Describe the bug
After the last release, related to PR #130, when set with
disabled={false}
, testing-library unit tests will fail if they haveexpect(pagination button).not.toBeDisabled()
How to reproduce
main...ashleyryan:core:asryan/pagination-test
Steps to reproduce the behavior:
Expected behavior
The test should pass because the button is not disabled, but it's being rendered with
disabled="false"
. This started happening after #130 with the change of the disabled attribute in the base button from a simple property to a getter/setter. Lit has a fix for this in the latest version of @lit-labs/reactVersions
Clarity project:
Clarity version:
Framework:
Framework version:
ie: Angular 11
Device:
Additional notes
Add any other notes about the problem here.
The text was updated successfully, but these errors were encountered: