Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): update disabled text color #167

Merged
merged 1 commit into from Sep 12, 2022

Conversation

ashleyryan
Copy link
Contributor

@ashleyryan ashleyryan commented Sep 9, 2022

fixes #165

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The text color in a disabled textarea didn't match the color of other disabled elements

Issue Number: #165

What is the new behavior?

The color now matches the color of other disabled inputs

image

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

👋 @ashleyryan,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, checkout out a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@ashleyryan
Copy link
Contributor Author

The color contrast of this doesn't pass, but I believe that the spec doesn't require disabled inputs to have the appropriate contrast?

@colinreedmiller
Copy link

The color contrast of this doesn't pass, but I believe that the spec doesn't require disabled inputs to have the appropriate contrast?

Correct. No contrast requirement for disabled items.

@ashleyryan ashleyryan merged commit 52922e1 into vmware-clarity:main Sep 12, 2022
@github-actions
Copy link

🎉 This PR is included in version 6.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CdsTextarea value isn't grayed out when disabled
4 participants