Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cds-modal margin is off without cds-modal-actions #174

Closed
2 of 8 tasks
ashleyryan opened this issue Sep 28, 2022 · 2 comments · Fixed by #175
Closed
2 of 8 tasks

cds-modal margin is off without cds-modal-actions #174

ashleyryan opened this issue Sep 28, 2022 · 2 comments · Fixed by #175
Labels

Comments

@ashleyryan
Copy link
Contributor

Describe the bug

When using a cds-modal without cds-modal-actions (aka the footer), there's very little margin at the bottom of the modal.

This is in contrast to how clr-modal works without the footer class.

How to reproduce

https://stackblitz.com/edit/clarity-typescript-demo-i53agv?file=src%2Findex.html

Open the two modals and compare the margin at the bottom when using an empty cds-modal-actions vs not.

Compare with clr-ui: https://stackblitz.com/edit/clarity-dark-theme-clr13-cds6-dwvuvf?file=src%2Fapp%2Fapp.component.html

Expected behavior

The behavior should more closely match clr-ui where margin exists even without the actions at the bottom.

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:
ie: Angular 11

Device:

  • Type: [e.g. MacBook]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional notes

Add any other notes about the problem here.

@github-actions
Copy link

🎉 This issue has been resolved in version 6.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant