Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cds control text overlaps with actions if initial display is hidden #182

Closed
3 of 8 tasks
ambar-arkin opened this issue Oct 27, 2022 · 2 comments · Fixed by #184
Closed
3 of 8 tasks

cds control text overlaps with actions if initial display is hidden #182

ambar-arkin opened this issue Oct 27, 2022 · 2 comments · Fixed by #184
Labels

Comments

@ambar-arkin
Copy link

Describe the bug

If initial display property of container is hidden and later changed to something else.
The cds control actions overlap with input text.

image

How to reproduce

https://stackblitz.com/edit/vitejs-vite-qng22i?file=src/App.jsx

Steps to reproduce the behavior:

  1. Uncheck hidden checkbox
  2. Type something long in text and search input
  3. See the text overlap with prefix and suffix actions

Expected behavior

The input text should start after the prefix action and end before it.

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:
React 18

Device:

  • Type: M1 Macbook pro
  • OS: macOS
  • Browser chromium
  • Version 106

Additional notes

This happens due to getBoundingClientRect giving unexpected result when display is none.

const start = pxToRem(this.prefixAction.getBoundingClientRect().width + 6);

@github-actions
Copy link

🎉 This issue has been resolved in version 6.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant