Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms > Required field - needs design modification to meet A11y requirements #623

Closed
lil-kim opened this issue Nov 15, 2022 · 4 comments
Closed

Forms > Required field - needs design modification to meet A11y requirements #623

lil-kim opened this issue Nov 15, 2022 · 4 comments
Labels
flag:stale type:feat

Comments

@lil-kim
Copy link

lil-kim commented Nov 15, 2022

Required field needs an asterisk to denote that it must be filled.

  • Currently Clarity recommends marking ONLY optional fields (as optional). All other fields are to be assumed as required. To be A11y (Maya Lin) compliant, the required fields need to be clearly marked with an asterisk with a legend/key at the top of the form.
  • Add this update to documentation in Clarity website.

Visual specs to follow.
@lil-kim lil-kim self-assigned this Nov 15, 2022
@lil-kim
Copy link
Author

lil-kim commented Nov 23, 2022

Here's the proposed modification. Needs review by @colinreedmiller and @AmyLiNow
https://www.figma.com/file/cCFMbq1f2n4DVxKT6zGIRn/GH-192-Form-Required-field?node-id=0%3A1&t=mJDayWimyGLQdLzu-1

@lil-kim
Copy link
Author

lil-kim commented Jan 19, 2023

@kevinbuhmann
The design is ready for implementation. Reviewed and approved by Amy Li and Colin Miller

Final and Spec.zip
doc images.zip

The attached images are also available in Figma: https://www.figma.com/file/cCFMbq1f2n4DVxKT6zGIRn/GH-192-Form-Required-field?node-id=249%3A577&t=JnqLgdjH28tp1lqY-1

Let me know if anything is unclear. Thanks!

This was referenced Mar 29, 2023
Closed
Merged
@kevinbuhmann kevinbuhmann transferred this issue from vmware-clarity/core Apr 4, 2023
dtsanevmw added a commit that referenced this issue Apr 20, 2023
@dtsanevmw @web-flow
feat(forms): add required mark class (#606)
deaf281 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)
- [x] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

All fields are assumed required and there is no way to tell that.

Issue Number: CDE-16, #623

## What is the new behavior?

Added a class which can be used to mark a container as required.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

---------

Co-authored-by: GitHub <noreply@github.com>
dtsanevmw added a commit that referenced this issue Apr 20, 2023
@dtsanevmw @web-flow
feat(forms): add required mark class (#606)
811578d 
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)
- [x] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

All fields are assumed required and there is no way to tell that.

Issue Number: CDE-16, #623

## What is the new behavior?

Added a class which can be used to mark a container as required.

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

---------

Co-authored-by: GitHub <noreply@github.com>
@kevinbuhmann
Copy link
Member

This has been done for a while.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flag:stale type:feat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kevinbuhmann @lil-kim