-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forms): add required mark class #606
Conversation
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
This PR introduces visual changes: 2f8c6fd
|
14a1ab2
to
d4f5295
Compare
I'm no longer sure if a CSS class the best way to do this. One thing we need to determine is how this shoukd work for screen reader users. This might turn out to be a bit more involved.
d4f5295
to
a0df3be
Compare
This PR introduces visual changes: 5da5302
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a11y review before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verified that asterisks are read with VO/Safari and NVDA/chrome.
## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tests for the changes have been added (for bug fixes / features) - [x] Docs have been added / updated (for bug fixes / features) - [x] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? <!-- Please check the one that applies to this PR using "x". --> - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? All fields are assumed required and there is no way to tell that. Issue Number: CDE-16, #623 ## What is the new behavior? Added a class which can be used to mark a container as required. ## Does this PR introduce a breaking change? - [ ] Yes - [x] No <!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> ## Other information --------- Co-authored-by: GitHub <noreply@github.com>
backport of #606 --------- Co-authored-by: GitHub <noreply@github.com>
🎉 This PR is included in version 15.3.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
All fields are assumed required and there is no way to tell that.
Issue Number: CDE-16, #623
What is the new behavior?
Added a class which can be used to mark a container as required.
Does this PR introduce a breaking change?
Other information