Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change - shim color mapping for side nav #195

Closed
colinreedmiller opened this issue Nov 29, 2022 · 3 comments · Fixed by #197
Closed

Change - shim color mapping for side nav #195

colinreedmiller opened this issue Nov 29, 2022 · 3 comments · Fixed by #197
Assignees
@kevinbuhmann
Labels
released

Comments

@colinreedmiller
Copy link

Users report hesitancy to adopt the shim because of inconsistency with the NG side nav.
Update the shim for the side-nav component to more closely align with the NG side-nav

The changes are:
BG: --cds-alias-object-container-background-tint
HOVER:-cds-alias-object-container-background-shade
ACTIVE: --cds-alias-object-container-background
@Jinnie
Copy link
Contributor

Jinnie commented Nov 30, 2022

Moving to the /vmware-clarity/core repo, where the shim code currently resides.
We have some plans to move the shim to ng-clarity, but so far it's not prioritized yet.

@Jinnie Jinnie transferred this issue from vmware-clarity/ng-clarity Nov 30, 2022
@kevinbuhmann kevinbuhmann self-assigned this Dec 1, 2022
kevinbuhmann added a commit that referenced this issue Dec 1, 2022
@kevinbuhmann
feat: update vertical nav shim background colors to match ng-clarity
44fd145 
closes #195
kevinbuhmann added a commit that referenced this issue Dec 1, 2022
@kevinbuhmann
feat: match ng-clarity vertical nav background colors in light shim
79239f6 
closes #195
@kevinbuhmann kevinbuhmann mentioned this issue Dec 1, 2022
Merged
1 task
kevinbuhmann added a commit that referenced this issue Dec 5, 2022
@kevinbuhmann
feat(shim): match light ng-clarity vertical nav background colors
829d4d9 
closes #195
kevinbuhmann added a commit that referenced this issue Dec 5, 2022
@kevinbuhmann
fix(shim): match light ng-clarity vertical nav background colors
d9f237d 
closes #195
kevinbuhmann added a commit that referenced this issue Dec 5, 2022
@kevinbuhmann
fix(shim): match light ng-clarity vertical nav background colors
5b1a6e0 
closes #195
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

🎉 This issue has been resolved in version 6.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevinbuhmann kevinbuhmann

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(shim): match light ng-clarity vertical nav background colors vmware-clarity/core
3 participants
@Jinnie @kevinbuhmann @colinreedmiller