Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkbox and radio do not update controller value with form's update on blur option #198

Closed
3 of 8 tasks
jtruffot opened this issue Dec 20, 2022 · 2 comments · Fixed by #199
Closed
3 of 8 tasks

Checkbox and radio do not update controller value with form's update on blur option #198

jtruffot opened this issue Dec 20, 2022 · 2 comments · Fixed by #199
Assignees
@kevinbuhmann
Labels
has-workaround released type:fix

Comments

@jtruffot
Copy link

Describe the bug

When using update on blur option of angular reactive form, checkbox and radio components do not update the value of their controller. The click on the component is correctly transmitted to the input but not the focus.

How to reproduce

Steps to reproduce the behavior:

  1. Go to this stackblitz example
  2. Click on checkbox or radio components
  3. Check that form value is not updated
  4. Activate workaround. Now form value is update on blur.

Expected behavior

Clicking on the checkbox and radio components should give them focus in order to update on the blur.

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:
Angular 13

Device:

  • OS: Linux
  • Browser Chrome, Firefox

Additional notes

A workaround is to give focus to the input on click.
@kevinbuhmann kevinbuhmann self-assigned this Dec 20, 2022
kevinbuhmann added a commit that referenced this issue Jan 5, 2023
@kevinbuhmann
fix(forms): focus checkbox/radio elements on click
c932284 
Previously, checkbox/radio elements were not focused on click of the
checkbox/radio. Clicking the label worked correctly, but not clicking
the checkbox/radio itself.

closes #198
@kevinbuhmann kevinbuhmann mentioned this issue Jan 5, 2023
Merged
kevinbuhmann added a commit that referenced this issue Jan 12, 2023
@kevinbuhmann
fix(forms): focus checkbox/radio elements on click
b3a773f 
Previously, checkbox/radio elements were not focused on click of the
checkbox/radio. Clicking the label worked correctly, but not clicking
the checkbox/radio itself.

closes #198
@github-actions
Copy link

🎉 This issue has been resolved in version 6.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevinbuhmann kevinbuhmann

Labels
has-workaround released type:fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(forms): focus checkbox/radio elements on click vmware-clarity/core
2 participants
@kevinbuhmann @jtruffot