Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cds-input styling is lost when using size attribute #55

Closed
2 of 4 tasks
ashleyryan opened this issue Apr 28, 2022 · 4 comments · Fixed by #58
Closed
2 of 4 tasks

cds-input styling is lost when using size attribute #55

ashleyryan opened this issue Apr 28, 2022 · 4 comments · Fixed by #58

Comments

@ashleyryan
Copy link
Contributor

This is ported from vmware-archive/clarity#6646

Describe the bug

The Editable pagination number example of the Pagination component from docs/Storybook lost its styles for the pagination number input.

It's caused by vmware-archive/clarity#6377, which also affects cds-input with a size attribute, not only cds-select. But perhaps it was intention?

How to reproduce

https://stackblitz.com/edit/clarity-cdn-wnbbpm?file=index.html

Note the difference in input behavior when using the size attribute on the input

Expected behavior

This appears to be caused by: vmware-archive/clarity#6377

Versions

Clarity version:

  • v3.x
  • v4.x
  • v5.x
  • v6.x

Additional notes

Add any other notes about the problem here.

@ashleyryan ashleyryan changed the title cds-input styling is offwhen using size attribute cds-input styling is lost when using size attribute Apr 28, 2022
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Apr 28, 2022
fixes vmware-clarity#55

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Apr 28, 2022
fixes vmware-clarity#55

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit that referenced this issue May 2, 2022
fixes #55

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit that referenced this issue May 2, 2022
fixes #55

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@github-actions
Copy link

github-actions bot commented May 2, 2022

🎉 This issue has been resolved in version 5.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented May 2, 2022

🎉 This issue has been resolved in version 6.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented May 3, 2022

🎉 This issue has been resolved in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant