Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clr-ui shim issues #71

Closed
12 of 19 tasks
ashleyryan opened this issue May 17, 2022 · 1 comment
Closed
12 of 19 tasks

clr-ui shim issues #71

ashleyryan opened this issue May 17, 2022 · 1 comment
Assignees
Labels

Comments

@ashleyryan
Copy link
Contributor

ashleyryan commented May 17, 2022

Describe the bug

Some of the ng components aren't styled correctly with the shim.

https://6282ae49fdaf3a0c394b6c68--clr-angular-demo.netlify.app/

Components

Accordion (light mode)

  • clr-accordion-header background color (--clr-accordion-header-background-color) should be --cds-alias-object-container-background-tint, not --cds-alias-object-app-background.
  • clr-accordion-header text color (--clr-accordion-text-color) should be --cds-alias-object-interaction-color
  • clr-accordion-title font-weight? Core doesn't have the same concept of a title vs description that ng does
  • Spacing between caret and title (will require ng change to add CSS var)

Alert (light mode)

  • danger alert font color should be --cds-global-typography-color-400 not --cds-global-typography-color-500
  • warning font color --clr-alert-warning-font-color should be --cds-global-color-construction-900 not var(--cds-global-color-black)
  • info font color --clr-alert-info-font-color should be --cds-global-typography-color-400 not --cds-global-typography-color-500
  • success font color --clr-alert-success-font-color should be --cds-global-typography-color-400 not --cds-global-typography-color-500

Badge

  • Default badge color doesn't have a CSS variable to change
  • Orange badge color --clr-badge-orange-bg-color: should be --cds-global-color-tangerine-400 not ochre
  • Blue badge color --clr-badge-light-blue-bg-colo should be blue 300, not 400

Card

  • Drop Shadow is different in ng vs Core (not controllable by CSS var)

Card (dark mode)

  • Card Content bottom border should match the horizontal divider color in Core (not controllable by CSS var)

Forms

  • label colors (--clr-forms-label-color) should use --cds-global-typography-color-400

Labels (tags)

  • Purple border color should be --cds-global-color-violet-600 not 500

Signposts

  • Drop Shadow is different in NG vs Core
  • Border Color --clr-signpost-content-border-color should be --cds-alias-object-border-color

Vertical Nav

  • Container background color is blue instead of white(ish). Should be --cds-alias-object-container-background
  • Icons when collapsed are left aligned in Core and center-aligned in Angular
@ashleyryan ashleyryan self-assigned this May 17, 2022
ashleyryan pushed a commit to ashleyryan/core that referenced this issue May 17, 2022
Addresses vmware-clarity#71

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit to ashleyryan/core that referenced this issue May 20, 2022
Addresses vmware-clarity#71

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit to ashleyryan/core that referenced this issue May 20, 2022
Addresses vmware-clarity#71

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit that referenced this issue May 25, 2022
Addresses #71

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants