Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography: h and p styles don't work in dark-mode #74

Closed
2 of 8 tasks
ashleyryan opened this issue May 20, 2022 · 2 comments
Closed
2 of 8 tasks

Typography: h and p styles don't work in dark-mode #74

ashleyryan opened this issue May 20, 2022 · 2 comments
Assignees

Comments

@ashleyryan
Copy link
Contributor

Describe the bug

There is no dark mode equivalent for the h and p styles in storybook, they show up as dark text

How to reproduce

scroll down to the headings h1-h6 and the paragraphs p1-p6 sections

https://clarity.design/storybook/core/?path=/story/foundation-typography--page&globals=theme:dark

Expected behavior

The text is readable on a dark background

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:
ie: Angular 11

Device:

  • Type: [e.g. MacBook]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional notes

Add any other notes about the problem here.

@ashleyryan ashleyryan self-assigned this May 20, 2022
ashleyryan pushed a commit to ashleyryan/core that referenced this issue May 23, 2022
- match the colors of the other typography classes
- get the colors working in dark mode

Fixes vmware-clarity#74

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit to ashleyryan/core that referenced this issue May 23, 2022
- match the colors of the other typography classes
- get the colors working in dark mode

Fixes vmware-clarity#74

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@github-actions
Copy link

🎉 This issue has been resolved in version 6.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant