Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core navigation issue with *ngIf and async pipe #82

Closed
4 of 8 tasks
bbogdanov opened this issue May 30, 2022 · 2 comments
Closed
4 of 8 tasks

Core navigation issue with *ngIf and async pipe #82

bbogdanov opened this issue May 30, 2022 · 2 comments
Labels
project:@cds/angular released on @5.x type:fix

Comments

@bbogdanov
Copy link
Contributor

Describe the bug

For some reason if you use *ngIf="someObseravble$ | async" on an cds-navigation-item or cds-navigation-group the icon seems to show but the label is missing.

How to reproduce

Please provide a link to a reproduction scenario using one of the Clarity Stackblitz templates. Reports without a clear reproduction may not be prioritized until one is provided.

Steps to reproduce the behavior:

  1. Add core navigation in an app
  2. Add an observable in your component controller
  3. Add *ngIf="someObseravble$ | async" on some item of the navigation that has cds-icon and a label
  4. See the label is missing

https://stackblitz.com/edit/clarity-light-theme-clr13-cds6-xn1gwx

Expected behavior

The item label is displayed on the screen after the observable resolves.

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v5.x
  • v6.x

Framework:

  • Angular
  • React
  • Vue
  • Other:
@bbogdanov bbogdanov mentioned this issue Aug 22, 2022
Closed
6 tasks
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Aug 23, 2022
fix(navigation): sync state with newly added nav items
c9536a6 
fixes  vmware-clarity#155 vmware-clarity#82

- previously only nav items in the initial render were synced with the top level expanded state
- add onslotchange to check for that
- move tabindex logic to slot change handler as well
- reorder component functions to match best practices
- update unit tests to check syncing after component updates
@ashleyryan ashleyryan mentioned this issue Aug 23, 2022
Merged
14 tasks
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Aug 23, 2022
fix(navigation): sync state with newly added nav items
41efc73 
fixes  vmware-clarity#155 vmware-clarity#82

- previously only nav items in the initial render were synced with the top level expanded state
- add onslotchange to check for that
- move tabindex logic to slot change handler as well
- reorder component functions to match best practices
- update unit tests to check syncing after component updates
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Aug 24, 2022
fix(navigation): sync state with newly added nav items
7b81dbe 
fixes  vmware-clarity#155 vmware-clarity#82

- previously only nav items in the initial render were synced with the top level expanded state
- add onslotchange to check for that
- move tabindex logic to slot change handler as well
- reorder component functions to match best practices
- update unit tests to check syncing after component updates
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Aug 24, 2022
fix(navigation): sync state with newly added nav items
a316a59 
fixes  vmware-clarity#155 vmware-clarity#82

- previously only nav items in the initial render were synced with the top level expanded state
- add onslotchange to check for that
- move tabindex logic to slot change handler as well
- update unit tests to check syncing after component updates
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Aug 24, 2022
fix(navigation): sync state with newly added nav items
fcbd0cd 
fixes  vmware-clarity#155 vmware-clarity#82

- previously only nav items in the initial render were synced with the top level expanded state
- add onslotchange to check for that
- move tabindex logic to slot change handler as well
- update unit tests to check syncing after component updates
ashleyryan pushed a commit that referenced this issue Aug 24, 2022
@ashleyryan
fix(navigation): sync state with newly added nav items
6c48eff 
fixes  #155 #82

- previously only nav items in the initial render were synced with the top level expanded state
- add onslotchange to check for that
- move tabindex logic to slot change handler as well
- update unit tests to check syncing after component updates
ashleyryan pushed a commit to ashleyryan/core that referenced this issue Aug 24, 2022
fix(navigation): sync state with newly added nav items
ff6c09c 
fixes  vmware-clarity#155 vmware-clarity#82

- previously only nav items in the initial render were synced with the top level expanded state
- add onslotchange to check for that
- move tabindex logic to slot change handler as well
- update unit tests to check syncing after component updates
@ashleyryan ashleyryan mentioned this issue Aug 24, 2022
Merged
ashleyryan pushed a commit that referenced this issue Aug 24, 2022
@ashleyryan
fix(navigation): sync state with newly added nav items
29c063b 
fixes  #155 #82

- previously only nav items in the initial render were synced with the top level expanded state
- add onslotchange to check for that
- move tabindex logic to slot change handler as well
- update unit tests to check syncing after component updates
@github-actions
Copy link

🎉 This issue has been resolved in version 5.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
project:@cds/angular released on @5.x type:fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashleyryan @bbogdanov