fix(modal): rerender modal when action slot is added #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @ashleyryan,
Thank you, 🤖 Clarity Release Bot |
ashleyryan
force-pushed
the
asryan/modal-actions
branch
from
8332df1
to
9e4c267
Compare
kevinbuhmann
reviewed
Nov 2, 2022
ashleyryan
force-pushed
the
asryan/modal-actions
branch
from
9e4c267
to
11ae70e
Compare
- the slot decorator doesnt update when the slot changes, so a slot listener must be added - a slot lister cannot be added to a slot that doesnt exist - instead, always render the slot, but use the hidden attribute - the slot change event will force the component to update and get the new value of the slot property fixes vmware-clarity#188
ashleyryan
force-pushed
the
asryan/modal-actions
branch
from
11ae70e
to
3f49490
Compare
kevinbuhmann
approved these changes
Nov 2, 2022
|
🎉 This PR is included in version 6.2.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #188
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When the actions are supplied asynchronously, they don't show up.
Issue Number: #188
What is the new behavior?
The slot is rendered all the time, just with a hidden attribute. A slot listener was added to make sure the component rerenders to remove the hidden attribute
Does this PR introduce a breaking change?
Other information