fix(cds-icon): fix globalstateservice memory leak #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure the component is connected before subscribing to the globalstateservice Fixes vmware-clarity#61 Signed-off-by: Ashley Ryan <asryan@vmware.com>
|
👋 @ashleyryan,
Thank you, 🤖 Clarity Release Bot |
ashleyryan
commented
May 25, 2022
| div.appendChild(icon); | ||
| icon.remove(); | ||
|
|
||
| await new Promise(resolve => setTimeout(resolve, 0)); |
There was a problem hiding this comment.
this is rough, but I don't have a web component to wait on since I'm explicitly removing it immediately above.
bbogdanov
approved these changes
May 25, 2022
Jinnie
approved these changes
May 26, 2022
|
🎉 This PR is included in version 6.0.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure the component is connected before subscribing to the globalstateservice
Fixes #61
Signed-off-by: Ashley Ryan asryan@vmware.com
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
When an element is immediately removed from the DOM,
firstUpdatedcan be called afterdisconnectedCallback, resulting in an event listener created that never gets removed.https://developer.mozilla.org/en-US/docs/Web/API/Node/isConnected
https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_custom_elements#using_the_lifecycle_callbacks
Issue Number: #61
What is the new behavior?
Added a check that the component is connected before creating the event listener
Does this PR introduce a breaking change?
Other information