Skip to content

Commit

Permalink
feat(stack-view): remove dead stack view setsize and posinset inputs
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
- The `clrStackViewSetsize` input has been removed.
- The `clrStackViewPosinset` input has been removed.
- These inputs had no effect. The functionality was previously removed.
  • Loading branch information
kevinbuhmann committed Dec 19, 2022
1 parent 5465f80 commit 5f37608
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 32 deletions.
2 changes: 0 additions & 2 deletions .storybook/stories/stack-view/stack-block.stories.ts
Expand Up @@ -39,8 +39,6 @@ const defaultParameters: Parameters = {
argTypes: {
// inputs
clrSbNotifyChange: { control: { disable: true }, table: { disable: true } }, // experimental
clrStackViewPosinset: { control: { disable: true }, table: { disable: true } }, // deprecated
clrStackViewSetsize: { control: { disable: true }, table: { disable: true } }, // deprecated
// outputs
clrSbExpandedChange: { control: { disable: true }, table: { disable: true } },
// methods
Expand Down
6 changes: 1 addition & 5 deletions projects/angular/clarity.api.md
Expand Up @@ -3678,10 +3678,6 @@ export class ClrStackBlock implements OnInit {
// (undocumented)
get ariaExpanded(): string;
ariaLevel: number;
// @deprecated (undocumented)
ariaPosinset: number;
// @deprecated (undocumented)
ariaSetsize: number;
// (undocumented)
get caretDirection(): string;
// (undocumented)
Expand Down Expand Up @@ -3719,7 +3715,7 @@ export class ClrStackBlock implements OnInit {
// (undocumented)
uniqueId: string;
// (undocumented)
static ɵcmp: i0.ɵɵComponentDeclaration<ClrStackBlock, "clr-stack-block", never, { "expanded": "clrSbExpanded"; "expandable": "clrSbExpandable"; "setChangedValue": "clrSbNotifyChange"; "ariaLevel": "clrStackViewLevel"; "ariaSetsize": "clrStackViewSetsize"; "ariaPosinset": "clrStackViewPosinset"; }, { "expandedChange": "clrSbExpandedChange"; }, ["stackBlockTitle"], ["clr-stack-label", "*", "clr-stack-block"], false, never>;
static ɵcmp: i0.ɵɵComponentDeclaration<ClrStackBlock, "clr-stack-block", never, { "expanded": "clrSbExpanded"; "expandable": "clrSbExpandable"; "setChangedValue": "clrSbNotifyChange"; "ariaLevel": "clrStackViewLevel"; }, { "expandedChange": "clrSbExpandedChange"; }, ["stackBlockTitle"], ["clr-stack-label", "*", "clr-stack-block"], false, never>;
// (undocumented)
static ɵfac: i0.ɵɵFactoryDeclaration<ClrStackBlock, [{ optional: true; skipSelf: true; }, null]>;
}
Expand Down
8 changes: 1 addition & 7 deletions projects/angular/src/data/stack-view/stack-block.spec.ts
Expand Up @@ -15,11 +15,7 @@ import { ClrStackViewModule } from './stack-view.module';

@Component({
template: `
<clr-stack-block
[clrStackViewLevel]="ariaLevel"
[clrStackViewSetsize]="ariaSetsize"
[clrStackViewPosinset]="ariaPosinset"
>
<clr-stack-block [clrStackViewLevel]="ariaLevel">
<clr-stack-label>Label</clr-stack-label>
<clr-stack-content>Content</clr-stack-content>
</clr-stack-block>
Expand All @@ -28,8 +24,6 @@ import { ClrStackViewModule } from './stack-view.module';
class BasicBlock {
@ViewChild(ClrStackBlock) blockInstance: ClrStackBlock;
ariaLevel: number;
ariaSetsize: number;
ariaPosinset: number;
}

@Component({
Expand Down
18 changes: 0 additions & 18 deletions projects/angular/src/data/stack-view/stack-block.ts
Expand Up @@ -133,24 +133,6 @@ export class ClrStackBlock implements OnInit {
*/
@Input('clrStackViewLevel') ariaLevel: number;

/**
* @deprecated
* Total number of rows in a given group
* - removed per a11y (see: VPAT-592)
* - remains here and unused to avoid breaking change to the public API
* - remove in v14
*/
@Input('clrStackViewSetsize') ariaSetsize: number;

/**
* @deprecated
* The position of the row inside the grouped by level rows
* - removed per a11y (see: VPAT-592)
* - remains here and unused to avoid breaking change to the public API
* - remove in v14
*/
@Input('clrStackViewPosinset') ariaPosinset: number;

/*
* This would be more efficient with @ContentChildren, with the parent ClrStackBlock
* querying for children StackBlocks, but this feature is not available when downgrading
Expand Down

0 comments on commit 5f37608

Please sign in to comment.