feat: add placeholder to datagrid string filter

This is a backport of 1cffda0. Committed-by: Kevin Buhmann <kbuhmann@vmware.com>
vmware-clarity · Jun 8, 2022 · 77dc157 · 77dc157
1 parent ec7d423
commit 77dc157
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.spec.ts b/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.spec.ts
@@ -122,6 +122,13 @@ export default function (): void {
       expect(input.getAttribute('aria-label')).toBe('Filter items');
       tick();
     }));
+
+    it('has placeholder on the input', fakeAsync(function () {
+      openFilter();
+      const input: HTMLInputElement = document.querySelector("input[type='text']");
+      expect(input.getAttribute('placeholder')).toBe('Filter items');
+      tick();
+    }));
   });
 }
 

diff --git a/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.ts b/projects/angular/src/data/datagrid/built-in/filters/datagrid-string-filter.ts
@@ -29,6 +29,7 @@ import { DatagridStringFilterImpl } from './datagrid-string-filter-impl';
         [(ngModel)]="value"
         class="clr-input"
         [attr.aria-label]="commonStrings.keys.filterItems"
+        [placeholder]="commonStrings.keys.filterItems"
       />
     </clr-dg-filter>
   `,