fix(vertical-nav): stop unnecessarily animating overflow-y

This prevents an Angular 14 developer warning. closes #323
vmware-clarity · Nov 14, 2022 · 9c936df · 9c936df
1 parent dba1099
commit 9c936df
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/projects/angular/src/layout/vertical-nav/_vertical-nav.clarity.scss b/projects/angular/src/layout/vertical-nav/_vertical-nav.clarity.scss
@@ -159,6 +159,10 @@
       }
     }
 
+    .nav-group-children {
+      overflow-y: hidden;
+    }
+
     .nav-trigger,
     .nav-group-trigger {
       //Display

diff --git a/projects/angular/src/layout/vertical-nav/vertical-nav-group.ts b/projects/angular/src/layout/vertical-nav/vertical-nav-group.ts
@@ -24,7 +24,7 @@ const COLLAPSED_STATE = 'collapsed';
   animations: [
     trigger('clrExpand', [
       state(EXPANDED_STATE, style({ height: '*' })),
-      state(COLLAPSED_STATE, style({ height: 0, 'overflow-y': 'hidden', visibility: 'hidden' })),
+      state(COLLAPSED_STATE, style({ height: 0, visibility: 'hidden' })),
       transition(`${EXPANDED_STATE} <=> ${COLLAPSED_STATE}`, animate('0.2s ease-in-out')),
     ]),
   ],