Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datagrid: Close icon in Datagrid pane should be grey, not blue #130

Closed
2 of 3 tasks
ashleyryan opened this issue May 25, 2022 · 4 comments · Fixed by #132
Closed
2 of 3 tasks

Datagrid: Close icon in Datagrid pane should be grey, not blue #130

ashleyryan opened this issue May 25, 2022 · 4 comments · Fixed by #132
Assignees
@ashleyryan
Labels
released on @12.x released

Comments

@ashleyryan
Copy link

Describe the bug

The close button in the detail pain of a datagrid should be the same grey color as other interactions (like modal), not blue.

How to reproduce

https://angular.clarity.design/documentation/datagrid/detail-pane

  1. Open a detail pane by clicking on one of the >> icons in the grid
  2. Notice that the close icon is blue

Expected behavior

The icon should be grey

Versions

Clarity version:

  • v12.x
  • v13.x
  • Other:
ashleyryan pushed a commit to ashleyryan/ng-clarity that referenced this issue May 25, 2022
fix(datagrid): update detail pane close icon color to match modal
2894433 
It should be grey, not blue

Fixes vmware-clarity#130

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@ashleyryan ashleyryan mentioned this issue May 25, 2022
Merged
13 tasks
@ashleyryan ashleyryan self-assigned this May 25, 2022
ashleyryan pushed a commit that referenced this issue May 25, 2022
@ashleyryan
fix(datagrid): update detail pane close icon color to match modal
09e6a1b 
It should be grey, not blue

Fixes #130

Signed-off-by: Ashley Ryan <asryan@vmware.com>
ashleyryan pushed a commit to ashleyryan/ng-clarity that referenced this issue May 25, 2022
fix(datagrid): update detail pane close icon color to match modal
f300a60 
It should be grey, not blue

Fixes vmware-clarity#130

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@ashleyryan ashleyryan mentioned this issue May 25, 2022
Merged
13 tasks
@s-vmw
Copy link

s-vmw commented May 25, 2022

Thank you, @ashleyryan and Colin Miller.

ashleyryan pushed a commit that referenced this issue May 26, 2022
@ashleyryan
fix(datagrid): update detail pane close icon color to match modal
f2a8741 
It should be grey, not blue

Fixes #130

Signed-off-by: Ashley Ryan <asryan@vmware.com>
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 12.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 13.3.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ashleyryan ashleyryan

Labels
released on @12.x released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(datagrid): update detail pane close icon color to match modal ashleyryan/ng-clarity
2 participants
@ashleyryan @s-vmw