Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselection combobox not showing properly on small devices #139

Closed
5 tasks
Eboru opened this issue May 29, 2022 · 4 comments · Fixed by #151
Closed
5 tasks

Multiselection combobox not showing properly on small devices #139

Eboru opened this issue May 29, 2022 · 4 comments · Fixed by #151

Comments

@Eboru
Copy link

Eboru commented May 29, 2022

Describe the bug

Multiselection combobox overflow on small screen, making it difficult to use since arrow is not shown.
This is because clr-combobox-wrapper.multi min-width is set to 18rem

How to reproduce

https://stackblitz.com/edit/clarity-dark-theme-clr12-cds5-vltppw?file=src%2Fapp%2Fapp.component.html
There's a fix on app.component.css

Steps to reproduce the behavior:

  1. Create a stepper
  2. Create a multiselection combo box
  3. Set a small viewport (example iPhoneSE 475x667)

Expected behavior

Multiselection combobox should not overflow

Versions

Clarity version:

  • v12.x
  • [ X] v13.x
  • Other:

Framework:

  • [ X] Angular
  • React
  • Vue
  • Other:

Framework version:
Angular 13

Device:

  • Browser [Brave/Chrome]

Additional notes

I write here the fix again
::ng-deep clr-combobox div.clr-combobox-wrapper.multi.clr-anchor {
min-width: unset !important;
}

By default
clr1

Where the problem lies
clr2

My solution, not sure if it is the best one i'm not used to css neither ui design
clr3

Hope this is usefull, it's my first bug report.

@Jinnie
Copy link
Contributor

Jinnie commented Jun 3, 2022

@Eboru thanks for the detailed research.
The problem, if I get it correctly, is that the wrapped input gets cut on the right side and the dropdown caret is not visible anymore.
We do need to have some minimal width there, which is the 18rem, but not if the viewport is smaller.
I think a good fix would be:

min-width: min(18rem, 100%);

Needs to be tested though.

@Jinnie Jinnie added the type:fix label Jun 3, 2022
@Jinnie Jinnie self-assigned this Jun 3, 2022
Jinnie added a commit to Jinnie/ng-clarity that referenced this issue Jun 6, 2022
…devices

closes vmware-clarity#106
closes vmware-clarity#139
Signed-off-by: Ivan Donchev <idonchev@vmware.com>
Jinnie added a commit that referenced this issue Jun 6, 2022
…devices

closes #106
closes #139
Signed-off-by: Ivan Donchev <idonchev@vmware.com>
Jinnie added a commit to Jinnie/ng-clarity that referenced this issue Jun 6, 2022
…devices

closes vmware-clarity#106
closes vmware-clarity#139
Signed-off-by: Ivan Donchev <idonchev@vmware.com>
Jinnie added a commit to Jinnie/ng-clarity that referenced this issue Jun 6, 2022
…devices

closes vmware-clarity#106
closes vmware-clarity#139
Signed-off-by: Ivan Donchev <idonchev@vmware.com>
Jinnie added a commit to Jinnie/ng-clarity that referenced this issue Jun 6, 2022
…devices

closes vmware-clarity#106
closes vmware-clarity#139
Signed-off-by: Ivan Donchev <idonchev@vmware.com>
Jinnie added a commit that referenced this issue Jun 6, 2022
…devices

closes #106
closes #139
Signed-off-by: Ivan Donchev <idonchev@vmware.com>
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

🎉 This issue has been resolved in version 12.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

🎉 This issue has been resolved in version 13.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants