Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default link behavior to have an underline #352

Closed
3 of 4 tasks
ashleyryan opened this issue Oct 19, 2022 · 3 comments · Fixed by #353
Closed
3 of 4 tasks

Set default link behavior to have an underline #352

ashleyryan opened this issue Oct 19, 2022 · 3 comments · Fixed by #353

Comments

@ashleyryan
Copy link

Describe the bug

By default, links don't have underline styling in NG. This is bad for accessibility. Add underline to links, like Core has: https://storybook.core.clarity.design/?path=/story/foundation-typography--page

VPAT-13812

Expected behavior

Links are underlined

Versions

Clarity version:

  • v12.x
  • v13.x
  • Other:

Framework:

  • Angular
ashleyryan pushed a commit to ashleyryan/ng-clarity that referenced this issue Oct 19, 2022
ashleyryan pushed a commit to ashleyryan/ng-clarity that referenced this issue Oct 19, 2022
BREAKING VISUAL CHANGE

fixes VPAT-13812, closes vmware-clarity#352
@Jinnie Jinnie self-assigned this Nov 21, 2022
@pdaigle pdaigle added the a11y label Dec 8, 2022
kevinbuhmann pushed a commit that referenced this issue Dec 12, 2022
kevinbuhmann pushed a commit that referenced this issue Dec 12, 2022
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 13.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 15.0.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants